search

couchbase / forestdb

A Fast Key-Value Storage Engine Based on Hierarchical B+-Tree Trie
Apache License 2.0
1.29k stars 173 forks source link

CMakeLists.txt: easily switch between static and shared libs #15

Closed markhpc closed 7 years ago

markhpc commented 7 years ago

This PR makes it easy to switch between building forestdb as a shared library or as a static library via the BUILD_SHARED_LIBS option. By default it will build a shared lib as before.

Building a static lib can be invoked ala:

cmake -DBUILD_SHARED_LIBS:bool=OFF

Signed-off-by: Mark Nelson mnelson@redhat.com

hisundar commented 7 years ago

Thanks for the patch! If this is your first code contribution to Couchbase, you'll need to fill out our Contributor License Agreement, which basically just declares that you created the code and are allowing us to release it under the Apache license.

hisundar commented 7 years ago

http://review.couchbase.org/#/settings/agreements

markhpc commented 7 years ago

I'm not sure I should sign any contributor license agreements per my employer, but I hear-by release this specific commit into the public domain so you may use it under any license you wish. :)

hisundar commented 7 years ago

Hi @markhpc , if you don't mind, may I just merge this commit via gerrit ? This way, you won't have to sign anything and I won't have to break any rules by accepting a change without the CLA signed?

hisundar commented 7 years ago

The fix has been merged. Thank you!