search

couchbase / forestdb

A Fast Key-Value Storage Engine Based on Hierarchical B+-Tree Trie
Apache License 2.0
1.29k stars 172 forks source link

Mingw32 compiler support #16

Open topilski opened 7 years ago

hisundar commented 7 years ago

Thanks for the patch! If this is your first code contribution to Couchbase, you'll need to fill out our Contributor License Agreement, which basically just declares that you created the code and are allowing us to release it under the Apache license. http://review.couchbase.org/#/settings/agreements Also changes to this repo are made via gerrit instead of pull requests.

topilski commented 7 years ago

Hi @hisundar , not interesting your style and your rules, don't want to merge please close it.

hisundar commented 7 years ago

hi @topilski, sorry you feel that way. Just curious, is your objection to signing the CLA or is it to the gerrit process or both? (Reason I ask is the former can't be fixed, while the latter possibly can). thanks

topilski commented 7 years ago

Hi @hisundar, why i should accept CLA if solution is opensource, i wrote 7 lines and should spent huge amount of time in gerrit system. You are a big guys, be easier, review pull request, if it interesting for you => merge it, if not => close it, if useful some line simple insert it into project and close request. Now your have last commit from 15 Mar it is 3 month ago, open rocksdb database and compare with your solution, or you can open redis, and also compare count of stars and time of last commit, less bla-bla-bla more work.