search

couchbase / forestdb

A Fast Key-Value Storage Engine Based on Hierarchical B+-Tree Trie
Apache License 2.0
1.29k stars 172 forks source link

Fails to build with VS 2019 #22

Open pjc158 opened 5 years ago

pjc158 commented 5 years ago

Hi Since upgrading to VS 2019 (16.3) ForestDB does not build. Anyone aware of this?

Phillip

hisundar commented 5 years ago

Could you please help share the error ?

pjc158 commented 5 years ago

Hi Sundar This is the link I have a ticket for with Microsoft

https://developercommunity.visualstudio.com/content/problem/799996/error-c2615-offsetof-cannot-be-applied-to-non-clas.html error C2615: 'offsetof' cannot be applied to non-class type - Developer Communityhttps://developercommunity.visualstudio.com/content/problem/799996/error-c2615-offsetof-cannot-be-applied-to-non-clas.html Developer Community for Visual Studio Product family developercommunity.visualstudio.com

I think it is a toolset issue with VS.

The line that fails VS 2019 is:

kvs_node = _get_entry(a, struct kvs_node, avl_name);

_get_entry is:

define _get_entry(ELEM, STRUCT, MEMBER)

((STRUCT ) ((uint8_t ) (ELEM) - offsetof (STRUCT, MEMBER)))

kv_instace.cc fails to compile.

In fact the only toolset that works is for VS 2015, 2017 has the same issue.

Regards Phillip Carruthers

From: Sundar Sridharan notifications@github.com Sent: 01 November 2019 03:24 To: couchbase/forestdb forestdb@noreply.github.com Cc: pjc158 pjc158@hotmail.co.uk; Author author@noreply.github.com Subject: Re: [couchbase/forestdb] Fails to build with VS 2019 (#22)

Could you please help share the error ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/couchbase/forestdb/issues/22?email_source=notifications&email_token=ABUALND2RIN5GGWKMQ5SBATQROOP3A5CNFSM4JGYQZC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECZ4IZA#issuecomment-548652132, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABUALNHYRK6KFI3JHZULSZ3QROOP3ANCNFSM4JGYQZCQ.

hisundar commented 5 years ago

Thanks so much, I think we will need to track this with the VS tools team.