couchbase / forestdb

A Fast Key-Value Storage Engine Based on Hierarchical B+-Tree Trie
Apache License 2.0
1.29k stars 173 forks source link

Database files larger than 2GB #8

Closed wiredprairie closed 9 years ago

wiredprairie commented 9 years ago

Database files larger than 2GB do not work on Windows as the 32bit version of the seek function returns a signed long, which causes downstream functions to fail as the offsets are no longer valid.

snej commented 9 years ago

You might want to file an issue on the Jira tracker, with a link here, to make sure the bug is visible. (Most Couchbase projects don't use Github issue trackers, and internal code reviews go through Gerrit, so PRs on Github may not have a lot of visibility.)

chiyoung commented 9 years ago

Aaron,

Thanks for identifying this issue on windows and suggesting the fix. As Jens mentioned above, we use Jira to track bugs on ForestDB. We will create a Jira ticket for this issue, and patch your fix and review / verify it through Gerrit soon.

Next time you find any issues on ForestDB, please use our Jira site to report a bug or make any suggestions.

Thanks!

chiyoung commented 9 years ago

The Jira ticket was created:

https://issues.couchbase.com/browse/MB-14321

The fix was pushed in Gerrit for review:

http://review.couchbase.org/#/c/49342/

wiredprairie commented 9 years ago

Thanks ... I didn't know about jira being your issue tracker.