search

couchbase / go-couchbase

Couchbase client in Go
https://godoc.org/github.com/couchbase/go-couchbase
MIT License
321 stars 92 forks source link

updated readme #65

Closed sbdchd closed 7 years ago

sbdchd commented 9 years ago

Fixed some spelling issues and adjusted the formatting.

tleyden commented 9 years ago

Thanks for this! Just a heads up though, we can't take PR's through this repository, they must be done via Gerrit reviews. And unfortunately, we don't have any instructions up on how to do this. I'll see what I can do to fix this situation, you aren't the first community user to get bitten by this.

@brett19 Hey I saw you had converted a few github PR's to Gerrit reviews. Do you have a slick way of doing this with the push of a button or did you just do it "by hand"?

tleyden commented 9 years ago

@sbdchd Can you register with our Review Site (http://review.couchbase.org) and accept our CLA? If you are already registered, ensure your Git Email is attached to your Gerrit Profile.

Sorry about the hassle..

sbdchd commented 9 years ago

I registered with Gerrit but do I need to do anything else?

Btw, Gerrit doesn't recognize .xyz email addresses as valid, which is the TLD that I use for my default address on github.

tleyden commented 9 years ago

@sbdchd nope, you're good! The ball is in our court now. @maniktaneja I will email you the internal wiki page that @brett19 sent me.

cb-sdk-robot commented 7 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

cb-sdk-robot commented 7 years ago

Unfortunately it has been 7 days and we are still unable to confirm that you have signed our CLA. We sincerely appreciate your submission and hope that you will register and resubmit this Pull Request in the future!

::SDKBOT/PR:timeout