search

couchbase / gocb-opentelemetry

Apache License 2.0
4 stars 8 forks source link

Not working for go 1.18 #6

Closed mkaratekin closed 8 months ago

mkaratekin commented 2 years ago

Hi,

It didn't work for go 1.18.

../../go/pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.0/metrics.go:35:35: meter.wrapped.NewInt64Counter undefined (type metric.Meter has no field or method NewInt64Counter) ../../go/pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.0/metrics.go:59:36: meter.wrapped.NewInt64ValueRecorder undefined (type metric.Meter has no field or method NewInt64ValueRecorder) ../../go/pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.0/metrics.go:79:17: undefined: metric.Int64Counter ../../go/pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.0/metrics.go:82:66: undefined: metric.Int64Counter ../../go/pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.0/metrics.go:95:17: undefined: metric.Int64ValueRecorder ../../go/pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.0/metrics.go:98:78: undefined: metric.Int64ValueRecorder ../../go/pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.0/tracing.go:59:39: undefined: attribute.Any

chvck commented 2 years ago

Hi @mkaratekin I've just cut a new release which contains a fix made back in March. I believe that this should address this issue. Please reopen this issue if you continue to see issues.

tony-clarke-amdocs commented 2 years ago

@chvck I just tried using version v0.1.1 and got the exact same error. I was using 1.18.2

chvck commented 2 years ago

Hi @tony-clarke-amdocs could you post the stacktrace that you see please? Parts of the above stacktrace don't actually make sense for the v0.1.1 tag.

tony-clarke-amdocs commented 2 years ago

Hi @chvck You are right it's a little different...

github.com/couchbase/gocb-opentelemetry ../../../../pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.1/metrics.go:35:35: meter.wrapped.NewInt64Counter undefined (type metric.Meter has no field or method NewInt64Counter) ../../../../pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.1/metrics.go:60:36: meter.wrapped.NewInt64Histogram undefined (type metric.Meter has no field or method NewInt64Histogram) ../../../../pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.1/metrics.go:79:20: undefined: metric.Int64Counter ../../../../pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.1/metrics.go:83:66: undefined: metric.Int64Counter ../../../../pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.1/metrics.go:97:20: undefined: metric.Int64Histogram ../../../../pkg/mod/github.com/couchbase/gocb-opentelemetry@v0.1.1/metrics.go:101:78: undefined: metric.Int64Histogram make: *** [build] Error 2

chvck commented 2 years ago

Hi @tony-clarke-amdocs we're unable to reproduce this, are you able to share a sample project or similar?

tony-clarke-amdocs commented 2 years ago

@chvck the current project is protected by company IP. If I get time I will try to reproduce independently.

chvck commented 8 months ago

I'm closing as, as far as I'm aware, this is no longer an issue.