search

couchbase / goforestdb

Go bindings for ForestDB
Apache License 2.0
37 stars 6 forks source link

Fix forestdb headers include paths #6

Closed t3rm1n4l closed 10 years ago

t3rm1n4l commented 10 years ago

Build system expects standard header directory path used by the forestdb cmake builds.

deepkaran commented 10 years ago

Please change the include path in this file as well: https://github.com/couchbaselabs/goforestdb/blob/master/examples/custom_comparator/comparator.c

mschoch commented 10 years ago

I haven't been keeping up with forestdb recently. I think at the time I last did this, the resulting Makefile didn't have an install target, and I just manually installed into those paths.

If cmake has a proper install target now, and these updates are the correct path, then please go ahead and merge these changes.

t3rm1n4l commented 10 years ago

Thanks for reviewing Marty. ForestDB has a cmake target, but somebody has to manually set that flag to install headers. Currently I am writing a build script that builds query and secondary indexing. Currently, I am setting my C_INCLUDE_PATH directly to the forestdb include directory in its source directory. Hence I need this change.