Closed mojavelinux closed 6 years ago
Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.
To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.
Keep in mind that the emails we are seeing on the commits are: d**s@couc*****.com
Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.
::SDKBOT/PR:no_cla
Hi Dan, Thanks for this. Do please create a Gerrit account using the link above and sign the CLA so the robot will import your changes into Gerrit. Make sure to use the d**s@couc*****.com
address when signing up so it can associate this pull request with your account. (If you already have a Gerrit account, you can add this email address in the Settings panel.)
Cheers,
David
David,
I accepted the agreement. However, I don't understand the part about the e-mail address. Why would I use an e-mail address that isn't mine? That seems counter-intuitive.
Oh, you're right! Sorry, I didn't realize the address on the commit wasn't yours. I think we have a process issue to sort out...
Oh, I see the problem now. Actually, that's probably my fault. I committed as the robot, but I didn't have to do that in this case. I can amend the commit so the author is my account. Shall I proceed with that?
Yes, please. Thanks!
Updated!
Your changes (commit: 5c46bcdf4f4b43b6778cd8108d6828d02e0c100a) have been pushed to the Couchbase Review Site: http://review.couchbase.org/98784
::SDKBOT/PR:created
It looks like the Gerrit integration doesn't respect the target branch specified in the PR. This change should be targeting releases/3.3 instead of master (there's another one for master).
I've submitted a help request for the branch mismatch issue. In the mean time, are you comfortable sending the change directly to Gerrit? If not, let me know and I'll amend the commit to use my email address and submit it to the correct branch on your behalf. If you want to take the plunge, here are the setup instructions:
SSH key setup:
Go through gerrit's Settings screen and set up your SSH keys. IMPORTANT: - do not forget to setup your username on the Settings screen.
Host review.couchbase.org
HostName review.couchbase.org
Port 29418
User
Then from the cb-docs-review-space/kafka-connect-couchbase
project directory:
git remote add gerrit ssh://<GERRIT_USERNAME>@review.couchbase.org:29418/kafka-connect-couchbase
And finally, to submit the commits on the current local branch for review:
git push gerrit HEAD:refs/for/<TARGET_BRANCH_NAME>
So in this case:
git checkout release/3.3-patched
git push gerrit HEAD:refs/for/release/3.3
Looks like it might take a while for the branch targeting issue to be resolved, so I've submitted to Gerrit on @mojavelinux's behalf: http://review.couchbase.org/#/c/98839/
This Pull Request has been closed as the associated Gerrit change was abandoned.
::SDKBOT/PR:abandoned
Original Gerrit change was abandoned because of the target branch issue. The Gerrit change targeting the correct branch has been merged.
Thank you @dnault! I appreciate your efforts to get this resolved this swiftly. We can now proceed with consuming the docs directly from this repository for the new site.