search

couchbase / kafka-connect-couchbase

Kafka Connect connector for Couchbase Server
https://issues.couchbase.com/projects/KAFKAC
Apache License 2.0
70 stars 71 forks source link

MINOR - Optimize Memory Allocations For sourcePartitions #15

Closed amcrn closed 5 years ago

amcrn commented 5 years ago

Set the initial capacity of the ArrayList to the known size. Simple, but effective enhancement for a method in the hot path.

cb-sdk-robot commented 5 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: amc*****lds@eb****om

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

amcrn commented 5 years ago

I authorize any contributor or maintainer of this repository to take my patch and make it their own (as the CLA bit introduces a hurdle).

amcrn commented 5 years ago

cc @dnault

dnault commented 5 years ago

Hi @amcrn , thanks for the PR.

Unless I'm missing something, CouchbaseSourceTask.sourcePartitions is called only once when the connector starts/restarts. Have you seen this method being called repeatedly?

I empathize with you about the CLA hurdle; it's something we acknowledge is an issue and would like to streamline in the future. In the mean time, we'd ask that you create a Gerrit account using the same amc*****lds@eb****om address associated with the PR. Then go to Settings / Agreements and click the box. Let us know if you run into any trouble during the process.

After you accept the CLA, you don't need to interact with Gerrit anymore if you don't want to; we can move the PR into Gerrit on your behalf.

cb-sdk-robot commented 5 years ago

Unfortunately it has been 7 days and we are still unable to confirm that you have signed our CLA. We sincerely appreciate your submission and hope that you will register and resubmit this Pull Request in the future!

::SDKBOT/PR:timeout