search

couchbase / kafka-connect-couchbase

Kafka Connect connector for Couchbase Server
https://issues.couchbase.com/projects/KAFKAC
Apache License 2.0
73 stars 72 forks source link

Enable noop to enable dead connection detection #5

Closed patrikn closed 6 years ago

patrikn commented 6 years ago

When we leave Couchbase idle for ~20 minutes, the DCP connection gets dropped by Couchbase, but the connector doesn't detect that it's no longer connected. Enabling noop appears to fix the problem by keeping the connection alive, and it doesn't seem there is any obvious reason why you wouldn't always want to run with noop enabled.

cb-sdk-robot commented 6 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: pn****bo@at****om

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

avsej commented 6 years ago

@patrikn when you will register on gerrit, make sure your email address there matches the one from this commit.

cb-sdk-robot commented 6 years ago

Your changes (commit: d7f3e65cc4aed5337e3b6bb30cfd44d44e23f771) have been pushed to the Couchbase Review Site: http://review.couchbase.org/89074

::SDKBOT/PR:created

dnault commented 6 years ago

Thank you, @patrikn

cb-sdk-robot commented 6 years ago

This Pull Request has been closed as the associated Gerrit change was merged.

::SDKBOT/PR:merged