search

couchbase / moss

moss - a simple, fast, ordered, persistable, key-val storage library for golang
Other
959 stars 58 forks source link

avoid deadlock by starting collection #62

Closed MatthiasRMS closed 5 years ago

MatthiasRMS commented 6 years ago

When running the Readme's example, you immediately run into an error since Start() hasn't been called on the collection. This will help getting the first example running without having to look around

cb-sdk-robot commented 6 years ago

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement.

Keep in mind that the emails we are seeing on the commits are: mat******rms@gma***com

Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed.

::SDKBOT/PR:no_cla

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 83.305% when pulling 2e3a176cdd21195ab5264e927dc13fbc7041c4d5 on MatthiasRMS:start-collection-readme-example into 956632ec1bc3e28276d00ee2f22c3202f06efb12 on couchbase:master.

cb-sdk-robot commented 6 years ago

Your changes (commit: 2e3a176cdd21195ab5264e927dc13fbc7041c4d5) have been pushed to the Couchbase Review Site: http://review.couchbase.org/101951

::SDKBOT/PR:created

cb-sdk-robot commented 5 years ago

This Pull Request has been closed as the associated Gerrit change was merged.

::SDKBOT/PR:merged