search

couchbase / protostellar

0 stars 3 forks source link

BooleanQuery changes + Added fields to SearchQueryResponse #29

Closed emilienbev closed 1 year ago

emilienbev commented 1 year ago

Motivation

The proto definition for SearchResult only contained a single "bytes hit = 1;", which made deserializing the object difficult in the SDKs. The aim here is to define each of the separate elements returned by the Search API in their own protobuf message to improve the SDKs implementations.

Additionally, BooleanQuery had an extra field not defined in the RFC (uint32 should_min) and didn't force must, must_not and should to be their distinct type of Query (respectively ConjunctionQuery and two DisjunctionQuery).

chvck commented 1 year ago

As this is a breaking change we can't fix the Buf Breaking but should fix up the lint.