search

couchbase / protostellar

0 stars 3 forks source link

Add support for history retention #72

Closed chvck closed 11 months ago

brett19 commented 12 months ago

This looks good, although it appears to be missing references to it's underlying tickets (which is a mix between https://couchbasecloud.atlassian.net/browse/ING-652 and https://couchbasecloud.atlassian.net/browse/ING-656 I believe).

chvck commented 11 months ago

Do we need to add the history fields to the ListBucket/GetBucket Responses?

Good spot.

brett19 commented 11 months ago

Something to consider here as well is that when creating a bucket, you can optionally omit the history settings to use the defaults. When updating, I don't believe there is a way to ask it to update the field back to the default?

chvck commented 11 months ago

Something to consider here as well is that when creating a bucket, you can optionally omit the history settings to use the defaults. When updating, I don't believe there is a way to ask it to update the field back to the default?

Do you mean creating a collection? You're correct if so, for the update case I can see what you're saying. Do we ever want to support cluster versions that don't support history retention? If so this needs to stay optional.