This is a more strict version of govet that is coming in go 1.24 and is already present in golangci-lint 1.24. All of the things flagged were false positives.
created NewHTTPError to cover when there are no arguments. I could have changed this code to NewHTTPErrorf(status, "%s", msg) but this seemed weird to me and like you wouldn't be sure why you had to use this code and would look this up.
Created FileLogger.log function but this could easily use logf("%s", msg) in the places we are using it like statsLogger and conditionalPrintf since they are called very irregularly.
I don't feel strongly about these implementation choices.
This is a more strict version of govet that is coming in go 1.24 and is already present in golangci-lint 1.24. All of the things flagged were false positives.
NewHTTPErrorto cover when there are no arguments. I could have changed this code toNewHTTPErrorf(status, "%s", msg)but this seemed weird to me and like you wouldn't be sure why you had to use this code and would look this up.FileLogger.logfunction but this could easily uselogf("%s", msg)in the places we are using it likestatsLoggerandconditionalPrintfsince they are called very irregularly.I don't feel strongly about these implementation choices.