Closed l0n3star closed 2 months ago
Hi @l0n3star I have a few questions regarding the above PR. Are we not validating whether the response from the API matches what is provided in the config file? It seems we are directly returning what is in the request. It would be better if we first validate whether the request and response times are the same despite having different formats. If they are the same, we should return what is being sent in the request; otherwise, we should return an error.
Also, do you remember our discussion about handling errors when resource creation fails? In such cases, Terraform marks the resource as tainted, and any subsequent terraform apply attempts to delete the resource. However, the deletion fails because the delete operation is not supported. We concluded that keeping the delete function of the resource empty would allow the resource to be removed from the state file.
What is your point of view on this issue? Should we incorporate that bug fix into this ticket, or should we create a new ticket for it?
Can you please also provide the validation proof for all the formats that we can pass and that return a successful response? We currently have only one case included in the validation proof
Also, do you remember our discussion about handling errors when resource creation fails? In such cases, Terraform marks the resource as tainted, and any subsequent terraform apply attempts to delete the resource. However, the deletion fails because the delete operation is not supported. We concluded that keeping the delete function of the resource empty would allow the resource to be removed from the state file.
What is your point of view on this issue? Should we incorporate that bug fix into this ticket, or should we create a new ticket for it?
I have separate PR for this: https://github.com/couchbasecloud/terraform-provider-couchbase-capella/pull/203
Hi @l0n3star I have a few questions regarding the above PR. Are we not validating whether the response from the API matches what is provided in the config file? It seems we are directly returning what is in the request. It would be better if we first validate whether the request and response times are the same despite having different formats. If they are the same, we should return what is being sent in the request; otherwise, we should return an error.
Good point. Addressed in https://github.com/couchbasecloud/terraform-provider-couchbase-capella/pull/199/commits/1c7bc529cdd7bbfc7222269d52b42dae676df2cb
Can you please also provide the validation proof for all the formats that we can pass and that return a successful response? We currently have only one case included in the validation proof
Sure. Updated PR with more validation.
closing as stale, please reopen whenever we are ready for a review. thanks
Jira
Description
When creating an audit log export request, if zulu format is used for the start/end times this results in a state mismatch because API server returns time with offsets.
Type of Change
Manual Testing Approach
How was this change tested and do you have evidence? (REQUIRED: Select at least 1)
Testing
validate zulu format
validate UTC time zone
validate pacific time zone:
Required Checklist:
Further comments