search

couchbaselabs / Couchbase.Extensions

Extensions for Couchbase for .Net Core
Apache License 2.0
27 stars 14 forks source link

3.3.5 - AddDistributedCouchbaseCache doesn't register IDistributedCache to DI like the overload with a bucket-name does #112

Open JonathanAtCenterEdge opened 11 months ago

JonathanAtCenterEdge commented 11 months ago

Previously in 3.3.4 https://github.com/couchbaselabs/Couchbase.Extensions/blob/master/src/Couchbase.Extensions.Caching/CouchbaseCacheServiceCollectionExtensions.cs#L19 would add the IDistributedCache to the service collection with CouchbaseCache as it's implementation, that was changed in 3.3.5 https://github.com/couchbaselabs/Couchbase.Extensions/commit/3207279a271bb3e1771460a6c9d981a691d40e92

https://github.com/couchbaselabs/Couchbase.Extensions/blob/master/src/Couchbase.Extensions.Caching/CouchbaseCacheServiceCollectionExtensions.cs#L48 that takes a bucket-name as it's first paramter DOES add IDistributedCache to the service collection with CouchbaseCache as it's implementation

This seems unintentional, and a major or minor change for what is supposed to be a patch version change

jeffrymorris commented 8 months ago

@JonathanAtCenterEdge thanks for reporting the issue! That does look like an unintentional bug.