Updated Absolute Property Logic And Adjusted Timespans (45)

mmmasent commented 6 years ago

Motivation

Prior, there was an issue where documents cached using the absolute properties were seemingly instantly deleted from the bucket

Adjusted GetLifeTime logic for the Absolute properties to return timespans relative to utc time:

AbsoluteExpirationRelativeToNow will return the timespan length that was passed to it (so passing timespan of 15 will return a timespan of 15)
AbsoluteExpiration will return a timespan whose length is equal to the AbsoluteExpiration date minus the UTC now date

Documents saved via the cache when using the absolute properties should no longer be instantly deleted

AppVeyorBot commented 6 years ago

jeffrymorris commented 6 years ago

Hi @mmmasent -

Looks good! Thanks for the submission!

-Jeff

jeffrymorris commented 6 years ago

@mmmasent -

Was doing some branch cleanup and it looks like I fixed(?) this same issue sometime back and never did the PR :(

I took yours over this and will merge this on top (possibly) since it adds some additional changes.

-Jeff