Uses async await instead of eliding

couchbaselabs / Couchbase.Extensions

Extensions for Couchbase for .Net Core

Apache License 2.0

27 stars 14 forks source link

Uses async await instead of eliding #61

Closed danielwertheim closed 5 years ago

danielwertheim commented 5 years ago

Stumbled upon one member in the cache that elides the call instead of using await and async as the other members do. Not really sure if it's by design or if it should be consistent.

AppVeyorBot commented 5 years ago

:white_check_mark: Build Couchbase.Extensions 128 completed (commit https://github.com/couchbaselabs/Couchbase.Extensions/commit/945e5c79fc by @danielwertheim)

jeffrymorris commented 5 years ago

Hi @danielwertheim -

Thanks for the submission. Wouldn't the caller of SetAsync just await the Task returned by the method?

-Jeff

danielwertheim commented 5 years ago

As it's not used in a disposable member eliding should probably be fine and let the consumer ensure he/she configures... Seen to code consistency, I guess RefreshAsync should elide as well then?

jeffrymorris commented 5 years ago

It's merged, Thanks!