search

couchbaselabs / ToDoLite-iOS

To-Do list sample app for Couchbase Lite, native iOS version
85 stars 41 forks source link

Fix sync function to support delete list correctly #74

Closed pasin closed 8 years ago

pasin commented 8 years ago
pasin commented 8 years ago

cc @tleyden @sethrosetter

pasin commented 8 years ago

@adamcfraser I fixed the sync function per your comment. Please review when you have time. Thanks!

adamcfraser commented 8 years ago

@pasin A minor point - I might change the thrown error message when owner != doc.owner from "no permission to modify the doc." to "Cannot change owner for lists", so it's more transparent what the error actually is (for end users, and for people using this sync function as a reference).

Otherwise it looks good to me.

pasin commented 8 years ago

Yes, I changed the message per your suggestion. Thanks!

pasin commented 8 years ago

I think we are good here so I'm merging this myself now.