Nesting fields to avoid bookeeping

couchbaselabs / cbfs

Distributed Blobstore using Couchbase Server

http://dustin.github.com/2012/09/27/cbfs.html

Apache License 2.0

188 stars 40 forks source link

Nesting fields to avoid bookeeping #125

Closed igm closed 11 years ago

igm commented 11 years ago

No need to explicitly name nested structures, we can use embedding.

ns-codereview commented 11 years ago

Issue has been moved to http://cbugg.hq.couchbase.com/bug/bug-693

dustin commented 11 years ago

I pulled this in as 0debf6483d6204c246839d5e043c8a624bcc799a with a minor change due to a tiny bug.

igm commented 11 years ago

My understanding is that these two lines are exactly the same:

res, err := t.RoundTrip(req)
res, err := t.RoundTripper.RoundTrip(req)

dustin commented 11 years ago

In general, yes. In this case, we're in a method called t.RoundTrip() so it's just a recursive call. :) It used up all my RAM on the stack extensions. You can see this with ^\

igm commented 11 years ago

oh well... very true. Now I got your comment about nesting