search

couchbaselabs / vscode-cblite

Apache License 2.0
11 stars 6 forks source link

fix: Fallback to unnamed id field for schema #7

Closed agg23 closed 2 years ago

agg23 commented 2 years ago

In some DB versions (pre-3.0?) meta().id does not resolve to a named column, but rather $1. This allows the plugin to fallback to that column if id isn't present.

borrrden commented 2 years ago

Those "some versions" you indicate are pre-release versions of 3.0 since SQL++ was not available in 2.x. I think this plugin is only going to be compatible with GA versions of 3.x.

frank-dspeed commented 2 years ago

I also vote for only 3+ as it already updates the database so it will always contain id

borrrden commented 2 years ago

It will never be compatible with 2.x since the underlying C library is only 3.x. What I meant was it will only be compatible with GA versions (as opposed to any development / prerelease versions). I think that will settle this.