search

couds / react-bulma-components

React components for Bulma framework
MIT License
1.2k stars 126 forks source link

v4: NavbarProps size is mandatory and only has one value #313

Closed davepwsmith closed 3 years ago

davepwsmith commented 3 years ago

Is this supposed to be a mandatory prop? Seems especially odd since there's only one allowed value.

interface NavbarProps {
  transparent?: boolean;
  fixed?: 'top' | 'bottom';
  size: 'large';
  color?: Color;
  active?: boolean;
}

Originally posted by @davepwsmith in https://github.com/couds/react-bulma-components/pull/265#r611058911

couds commented 3 years ago

Thanks for reporting this. nice catch!