couds / react-bulma-components

React components for Bulma framework
MIT License
1.2k stars 126 forks source link

Disabling dropdown does not work as it should. #332

Closed chonla closed 3 years ago

chonla commented 3 years ago

Describe the bug Disabling dropdown does not work as it should.

To Reproduce Steps to reproduce the behavior:

  1. Create <Dropdown disabled={true}> with some items.
  2. Open the rendered component.

Expected behavior Rendered Dropdown should be disabled, but it is not.

Versions

kennethnym commented 3 years ago

Can you upgrade to v4 and see if the issue persists? Thanks.

chonla commented 3 years ago

I have just upgraded to 4.0.4 and yes, the problem persists.

AFAIK, the disabled prop is not propagated to

kennethnym commented 3 years ago

I'll look into it.

couds commented 3 years ago

Hi @chonla. I was checking the bulma documentation Iand didn't found a disabled state for the dropdown. We can think on maybe add it but for know I prefer not to do it to not divert too much from Bulma.

If you want to add a feature request we can discuss it and see what the community think about. meanwhile I'm closing this due its not a bug

chonla commented 3 years ago

@couds I understand what you mean. In my opinion, you can disable the dropdown in bulma by disabling the dropdown-trigger which is a button.

The <Dropdown> component itself contain <Button> inside and does not allow me to disable.

Any suggestion?

couds commented 3 years ago

I think that make sense. then let's add a disabled prop to the dropdown that will disable the button.

couds commented 3 years ago

@chonla released on https://github.com/couds/react-bulma-components/releases/tag/v4.0.6

chonla commented 3 years ago

Thank you.