couds / react-bulma-components

React components for Bulma framework
MIT License
1.2k stars 126 forks source link

Storybook not rendering ArgsTable for Modal #350

Open Cleanshooter opened 3 years ago

Cleanshooter commented 3 years ago

Describe the bug Storybook not rendering ArgsTable for Modal

To Reproduce Steps to reproduce the behavior:

  1. Go to https://couds.github.io/react-bulma-components/iframe.html?id=components-modal--default&viewMode=docs#props
  2. See error "No inputs found for this component."

Expected behavior The props for the modal component should be displayed. (https://github.com/couds/react-bulma-components/blob/master/src/components/modal/modal.js)

Screenshots image

Versions

Additional context While I was using this and the docs yesterday I noticed that the was a discrepancy between the props I saw in the code and the documentation in Storybook for the modal component. Long story short (and after about 8 hours trying to fix it yesterday) I couldn't find a way to get it to show up in story book.

Things I've tried (a.k.a. the long story):

I'm wondering if anyone else has tried to fix this and what they've tried. At this point I'm stumped. The next thing I'd want to try is pretty drastic (redo the storybook config and use DocPages instead of MDX as a default) but I didn't think the repo maintainers would be onborad with such a drastic change.

The other thing I wondered is if we could somehow change the modal code so that storybook-addon-react-docgen would actually pick it up the props. I'm not exactly sure why it's not picking them up but I'm thinking it's related to one of the things mentioned in (FAQ - Nothing shows up, this is broken!) section on this page.

This is a great repo and I can tell you've put in a lot of work into this so far and I'd love to contribute but since I'm still fairly new to it I'm wondering if the primary maintainers have any ideas on this.

Cleanshooter commented 3 years ago

Possibly related... the ArgsTable for the Column component is missing the gap prop. It's weird because it lists all the other props.