couds / react-bulma-components

React components for Bulma framework
MIT License
1.2k stars 126 forks source link

added fullwidth prop to Select #359

Closed luhis closed 2 years ago

luhis commented 3 years ago

Checking the Bulma docs, the is-fullwidth class option is missing on the Select component: https://bulma.io/documentation/form/general/

I just followed the methodology used on the Control component, I hope this is what we need.

kennethnym commented 3 years ago

There is fullwidth prop already on the Control component that applies the is-expanded modifier. Does that not work properly?

luhis commented 3 years ago

There is fullwidth prop already on the Control component that applies the is-expanded modifier. Does that not work properly?

It works, but we also need to use is-fullwidth on the select container to get the select to be full width

couds commented 3 years ago

Hi Sorry for the late response, Event that the Bulma docs do not mention the is-fullwidth on the select I saw it on the scss code So I will merge this PR.

Thanks for the contribution