Closed RJSonnenberg closed 2 years ago
This PR appears to be a different resolution from the proposed solution: https://github.com/couds/react-bulma-components/pull/360
The proposed solution is in this PR: https://github.com/couds/react-bulma-components/pull/364
Grouped to #362, closing
Describe the bug When importing react-bulma-components in a React + TypeScript project with
skipLibCheck
set to false in thetsconfig.json
project file, the project fails to compile. Below is the output after runningnpm start
in the console:To Reproduce Steps to reproduce the behavior:
npx create-react-app rbc-bug-report --template typescript
npm install bulma bulma-react-components
tsconfig.json
in the project root directory and setskipLibCheck
tofalse
index.tsx
in the projectsrc
directory and addimport {} from 'react-bulma-components';
to the list of importsnpm start
Expected behavior The application should compile without error when importing react-bulma-components.
Versions
react-bulma-components:
:4.0.7
bulma
:0.9.3
react
:17.0.2
@types/react
:17.0.9
typescript
:4.3.5
Additional context I originally noticed this error in the .NET React Web App template.
Proposed Solution The
ImageProps
type needs to be exported: https://github.com/couds/react-bulma-components/blob/7d4d0f56979421957d26b6dc240adbf667f3d492/src/components/image/index.d.ts#L3 New:We need to explicitly import the
ImageProps
type: https://github.com/couds/react-bulma-components/blob/7d4d0f56979421957d26b6dc240adbf667f3d492/src/components/card/index.d.ts#L2 New: