search

couds / react-bulma-components

React components for Bulma framework
MIT License
1.2k stars 126 forks source link

Fix Card importing ImageProps bug #364

Closed RJSonnenberg closed 3 years ago

RJSonnenberg commented 3 years ago

Resolves issue https://github.com/couds/react-bulma-components/issues/363 where ImageProps type was not being properly exported from the Image type file and imported in Card type file.

kennethnym commented 3 years ago

Thanks for your PRs. I will review them when I'm free.

kennethnym commented 3 years ago

Hey @RJSonnenberg, sorry I have been quite busy for the past week. In #362 @petertodorov requested the ability to extend on built-in props which is not possible since Bulma component props are hidden from the user. I am planning to make a PR that makes the props public so that users can access them and extend on them, which will include exporting ImageProps. I will close this PR for now. #363 will be addressed by that PR as well.

RJSonnenberg commented 2 years ago

Hey @RJSonnenberg, sorry I have been quite busy for the past week. In #362 @petertodorov requested the ability to extend on built-in props which is not possible since Bulma component props are hidden from the user. I am planning to make a PR that makes the props public so that users can access them and extend on them, which will include exporting ImageProps. I will close this PR for now. #363 will be addressed by that PR as well.

@kennethnym Any progress on your PR?

kennethnym commented 2 years ago

Sorry, I'm pretty busy recently. I'll start working on it when I'm free.