Navbar-dropdown cant be a span element must be a div or other block element

couds / react-bulma-components

React components for Bulma framework

MIT License

1.2k stars 126 forks source link

Navbar-dropdown cant be a span element must be a div or other block element #372

Closed smeknamn closed 2 years ago

smeknamn commented 2 years ago

Describe the bug Using a divider converted as a hr element, is not allowed in proper html to be inside a list item span element. When validate my code in W3C's validator it says: Element hr not allowed as child of element span in this context.

The officiell Bulma uses div elements here, why have you change that to span?

smeknamn commented 2 years ago

renderAs="div" is a possible workaround. <Navbar.Item renderAs="div"> <Navbar.Dropdown renderAs="div"> <Link to="">Link</Link> </Navbar.Dropdown> </Navbar.Item>

kennethnym commented 2 years ago

Hi @smeknamn, I'll look into this next week. Thanks for reporting the issue!