couds / react-bulma-components

React components for Bulma framework
MIT License
1.2k stars 129 forks source link

fix: change signature of Breadcrumb #389

Closed arkadybag closed 2 years ago

arkadybag commented 2 years ago

Regarding to 1) Official Bulma documentation 2) this piece of code https://github.com/arkadybag/react-bulma-components/blob/master/src/components/breadcrumb/breadcrumb.js#L21

const Breadcrumb = ({
  className,
  separator,
  size,
  align,
  children,
  ...props
}) => {
  return (
    <Element
      {...props}
      className={classnames('breadcrumb', className, {
        [`has-${separator}-separator`]: separator,
        [`is-${size}`]: size,
        [`is-${align}`]: align,
      })}
    >
      <ul>{children}</ul>
    </Element>
  );
};

We need to change it as follow