couds / react-bulma-components

React components for Bulma framework
MIT License
1.2k stars 129 forks source link

defaultProps on function components is deprecated #418

Open davetapley opened 1 year ago

davetapley commented 1 year ago

Describe the bug

Causes:

Warning: Container: Support for defaultProps will be removed from function components in a future major release.
Use JavaScript default parameters instead.
    at Container
(webpack-internal:///(sc_client)/./node_modules/react-bulma-components/cjs/components/container/container.js:27:23)

Sure enough: https://github.com/couds/react-bulma-components/blob/82d13fc9d8c9ffee46c21318450127b92cbf128e/src/components/container/container.js#L39

And: https://github.com/couds/react-bulma-components/blob/82d13fc9d8c9ffee46c21318450127b92cbf128e/src/components/container/container.js#L7

Versions

Additional context

https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md#deprecate-defaultprops-on-function-components

77 files need patching. I can do it if maintainer will confirm this is still active and will get merged?

jirehnimes commented 1 year ago

Up on this one also. Thanks!

nicokant commented 1 month ago

any news about this?