search

couds / react-bulma-components

React components for Bulma framework
MIT License
1.21k stars 126 forks source link

All components should support `renderAs` prop #81

Closed RickEyre closed 6 years ago

RickEyre commented 6 years ago

This would be super useful and make the library much more flexible.

Thoughts?

couds commented 6 years ago

Hi @RickEyre All components support the prop RenderAs. If not that was by mistake. Did you found a component without the renderAs prop?

RickEyre commented 6 years ago

I was trying on Columns today and it was not. In the code it looks like it's hard-coded to div.

couds commented 6 years ago

Thanks Rick you are right. That was a mistake should have the renderAs prop. The next version will have that fixed

RickEyre commented 6 years ago

Thanks!

On Sun, Sep 23, 2018, 01:08 John, notifications@github.com wrote:

Thanks Rick you are right. That was a mistake should have the renderAs prop. The next version will have that fixed

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/couds/react-bulma-components/issues/81#issuecomment-423792399, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBY5Hrk-KrsX5MmRAfN4BPZv4h0Wo8yks5udxddgaJpZM4W1XmV .