I made several changes & Improvements I figured I would commit them back, but if you think any need to be changed let me know. This PR includes code from #6 so if you approve all the changes just merge this one and close that one.
Full list of changes/improvements:
Added filename path escaping
Added folder name path escaping
Changed initial MIN_VIEWS to 5k from 20k (missed a lot of downloads because I listen to weird stuff 😛 )
Added build files and log files to .gitignore
Set temp folder to be deleted after script finishes
Added skip existing (will check /downloads/<folder name>/<song name>.mp3 before downloading and skip if already present)
More granular error catching for common errors (also made most errors fail silently)
Added messaging at end to indicate failed downloads and reasons for failures (also included in logs)
Added Fail threshold to prompt user to attempt to redownload with half the set MIN_VIEWS value (i.e. script fails 6 songs and min views is 5k user will be asked if they want to re-run script with MIN_VIEWS set to 2.5k)
Added automatic playlist name pulling if no playlist name is specified (Pulls based on player HTML)
Improved documentation in readme with details about configuration you can change and where to get URL for playlist
I made several changes & Improvements I figured I would commit them back, but if you think any need to be changed let me know. This PR includes code from #6 so if you approve all the changes just merge this one and close that one.
Full list of changes/improvements:
MIN_VIEWS
to 5k from 20k (missed a lot of downloads because I listen to weird stuff 😛 ).gitignore
/downloads/<folder name>/<song name>.mp3
before downloading and skip if already present)MIN_VIEWS
value (i.e. script fails 6 songs and min views is 5k user will be asked if they want to re-run script withMIN_VIEWS
set to 2.5k)