search

couler-proj / couler

Unified Interface for Constructing and Managing Workflows on different workflow engines, such as Argo Workflows, Tekton Pipelines, and Apache Airflow.
https://couler-proj.github.io/couler/index.html
Apache License 2.0
908 stars 86 forks source link

Remove the `args` field from `Container` #225

Open moshewe opened 3 years ago

moshewe commented 3 years ago

Summary

According to the Argo documentation, container doesn't have an args field at all. It's used to put input parameters, with the input field used to put input artifacts (pulled in from the run_container method). It's counter-intuitive. I think a better solution would be to use the input field solely for the purpose of defining template inputs.

Use Cases

Better alignment with Argo docs, more intuitive code design and more fine grained container template definitions.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

terrytangyuan commented 3 years ago

Would you like to propose changes that are backwards compatible and perhaps add a deprecation warning?

moshewe commented 3 years ago

Deprecating it sounds like a good idea.