couler-proj / couler

Unified Interface for Constructing and Managing Workflows on different workflow engines, such as Argo Workflows, Tekton Pipelines, and Apache Airflow.
https://couler-proj.github.io/couler/index.html
Apache License 2.0
893 stars 86 forks source link

feat: Add image pull secrect support for python src #238

Closed lcgash closed 2 years ago

lcgash commented 2 years ago

What changes were proposed in this pull request?

add image pull secret config for workflow

Why are the changes needed?

because our project need pull image from private hub

Does this PR introduce any user-facing change?

i think no.it was a new feature.

How was this patch tested?

add one unit test and our project use this code to pull image

merlintang commented 2 years ago

@lcgash thanks for your contribution, can you fix the type issue at first?

merlintang commented 2 years ago

@lcgash can you update your pr description as well?

What changes were proposed in this pull request? Why are the changes needed? Does this PR introduce any user-facing change? How was this patch tested?

merlintang commented 2 years ago

pre-commit run --all @lcgash pls run precommit to help you to fix the format issue. sorry about this link error https://github.com/couler-proj/couler/blob/master/CONTRIBUTING.md#run-sanity-checks

lcgash commented 2 years ago

https://yuque.antfin.com/aii/kubemaker/mz5myx @lcgash pls run precommit to help you to fix the format issue sorry , i can not access it

lcgash commented 2 years ago

pre-commit run --all @lcgash pls run precommit to help you to fix the format issue. sorry about this link error https://github.com/couler-proj/couler/blob/master/CONTRIBUTING.md#run-sanity-checks

i got

lcgash commented 2 years ago

pre-commit run --all @lcgash pls run precommit to help you to fix the format issue. sorry about this link error https://github.com/couler-proj/couler/blob/master/CONTRIBUTING.md#run-sanity-checks

image it seems look ok. please review, thanks

merlintang commented 2 years ago

thanks @lcgash for your contribution. can you also send a pr to add your organization to the adopter of couler. https://github.com/couler-proj/couler/blob/master/ADOPTERS.md