search

couler-proj / couler

Unified Interface for Constructing and Managing Workflows on different workflow engines, such as Argo Workflows, Tekton Pipelines, and Apache Airflow.
https://couler-proj.github.io/couler/index.html
Apache License 2.0
908 stars 86 forks source link

Revert "home brew" code to official Python client #242

Open moshewe opened 2 years ago

moshewe commented 2 years ago

Summary

Change custom code to use the official Python API

Use Cases

It's difficult developing new features and onboarding new developers to the codebase, as the underlying structures don't follow the (well-documented) official Python API.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

terrytangyuan commented 2 years ago

What do you mean by "the official Python API"?

moshewe commented 2 years ago

https://github.com/argoproj-labs/argo-client-python

terrytangyuan commented 2 years ago

https://github.com/argoproj-labs/argo-client-python is unmaintained and you cannot easily support multiple versions of Argo Workflows either. We used it for validation but later removed it because there were some false positives.

moshewe commented 2 years ago

Can we use the OpenAPI specs then? Those are kept up to date... right?

On Mon, Oct 4, 2021 at 5:05 PM Yuan Tang @.***> wrote:

https://github.com/argoproj-labs/argo-client-python is unmaintained and you cannot easily support multiple versions of Argo Workflows either. We used it for validation but later removed it because there were some false positives.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/couler-proj/couler/issues/242#issuecomment-933521052, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXRO6OLCWTVI35KPCJLJTDUFGYEHANCNFSM5FHHDZTA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

tachyus-ryan commented 2 years ago

@moshewe I think you want https://github.com/argoproj/argo-workflows/tree/master/sdks/python

terrytangyuan commented 2 years ago

Please hold off on using https://github.com/argoproj/argo-workflows/tree/master/sdks/python until it's published to PyPI. There are still additional work to do there.