search

couler-proj / couler

Unified Interface for Constructing and Managing Workflows on different workflow engines, such as Argo Workflows, Tekton Pipelines, and Apache Airflow.
https://couler-proj.github.io/couler/index.html
Apache License 2.0
893 stars 86 forks source link

fix: Relax dependency version pinning. #244

Closed jmcarp closed 2 years ago

jmcarp commented 2 years ago

What changes were proposed in this pull request?

To avoid depencency version conflicts with other libraries, pin dependencies to version ranges rather than exact versions.

Why are the changes needed?

Let me know if you disagree, but in general I think library code should try to avoid pinning to exact versions. Otherwise it can get very tricky to resolve conflicts for non-trivial projects.

Does this PR introduce any user-facing change?

It's possible that there are breaking changes in dependencies that I don't know about! I'll wait for tests to run and see if anything breaks.

How was this patch tested?

See above: this change shouldn't require new tests.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

merlintang commented 2 years ago

thanks for your pr, I agree that we can not bind to a specific version.

merlintang commented 2 years ago

meanwhile, can you update the PR title like, fix: Relax dependency version pinning. @jmcarp

terrytangyuan commented 2 years ago

Looks like builds failed. Could you look into fixing them?

merlintang commented 2 years ago

can you pls sign the CLA @jmcarp

merlintang commented 2 years ago

thanks for your contribution @jmcarp