couler-proj / couler

Unified Interface for Constructing and Managing Workflows on different workflow engines, such as Argo Workflows, Tekton Pipelines, and Apache Airflow.
https://couler-proj.github.io/couler/index.html
Apache License 2.0
908 stars 86 forks source link

No insecure option for S3Artifact #254

Closed sifat007 closed 2 years ago

sifat007 commented 2 years ago

Summary

Ability to add insecure:true field to the S3 artifacts

...
inputs:
      artifacts:
        - name: my-input-artifact
          path: /my-input-artifact
          s3:
            endpoint: minio.argo.svc:9000
            insecure: true        <---------------------- Currently not possible from Couler
            bucket: foo
            key: coinflip-artifact.tgz
            accessKeySecret:
              name: minio-secrets
              key: accessKey
            secretKeySecret:
              name: minio-secrets
              key: secretKey
...

Use Cases

Running local minio without HTTPS

Any recommendation for workarounds?

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

sifat007 commented 2 years ago

Fixed by commit afa1277170daa430d1088eaf2a4758e1c1414e8e