search

couler-proj / couler

Unified Interface for Constructing and Managing Workflows on different workflow engines, such as Argo Workflows, Tekton Pipelines, and Apache Airflow.
https://couler-proj.github.io/couler/index.html
Apache License 2.0
893 stars 86 forks source link

feat: Enable insecure endpoint for S3Artifacts and S3Artifact usage when workflow is submitted to a namespace other than "default" #256

Closed sifat007 closed 2 years ago

sifat007 commented 2 years ago

S3Artifact endpoint can be set to be insecure (HTTP); Secrets do not have the "namespace: default" entry when no namespace is specified. This enables the use of S3Artifacts when running workflow in a namespace other than "default".

What changes were proposed in this pull request?

  1. Added a new argument insecure to the create_s3_artifact function.
  2. Secret yaml file does not put the "namespace: default" entry when no namespace is specified.

Why are the changes needed?

  1. S3Artifact Endpoint can be HTTP now
  2. Secret yaml file does not put the "namespace: default" entry when no namespace is specified. This enables the use of S3Artifacts to be used when workflow is submitted to a namespace other than "default". Previously it would cause an error where the secret created by the S3Artifact always has the "namespace: default" entry no matter which namespace the workflow is being submitted to.

    How was this patch tested?

    Existing unit tests passed. Couple of changes were made to the test methods to test the new source changes.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

merlintang commented 2 years ago

can you sign the CLA and update the PR title? thanks @sifat007