search

couling / WebDAV-Daemon

MIT License
34 stars 7 forks source link

Resumable upload #30

Closed dumblob closed 3 years ago

dumblob commented 3 years ago

Hi, I'm looking for a WebDAV server which could handle a storage of several terabytes of data (mainly pics & videos). Therefore I need to be absolutely sure the server supports resumable uploads (e.g. after network connection interruption or after smartphone restart etc.). Is it supported by default by webdavd? If not, could this be implemented?

And btw. do I need to care myself about SSL certificates or does webdavd have something like (optional) Let's Encrypt support like caddy does?

couling commented 3 years ago

At this time chunked upload is not supported. Checking the code, it would need to seek() just here: https://github.com/couling/WebDAV-Daemon/blob/93759c7df19a5ebc4fdb6d02ba9fd6cb547b9ea5/rap.c#L1262 but it doesn't. It would also need the appropriate header to be parsed and passed through...

And there I see a problem. I can't find anywhere in HTTP a way to make byte range based PUT or PATCH requests. There's no header nominated for it. @dumblob if you have a WebDAV client that does support resume on upload I'd be interested to know what headers it tries to send.

On the other hand this webdavd does support range requests on GET. IE downloads can be resumed as long as the content being downloaded is a file.

Unfortunately, I don't believe there's a way to implement the feature you're asking for so I'll close this issue. Feel free to re-open if you can find the right headers to support.

dumblob commented 3 years ago

And there I see a problem. I can't find anywhere in HTTP a way to make byte range based PUT or PATCH requests. There's no header nominated for it. @dumblob if you have a WebDAV client that does support resume on upload I'd be interested to know what headers it tries to send.

Unfortunately no WebDAV client I know of supports resumable uploads (and probably chunked uploads neither).

Some HTTP clients (e.g. curl) use a trick to overcome this issue, but it has its drawbacks - https://stackoverflow.com/a/32963259 . Some also prefer to (ab)use the freedom HTTP gives us: https://stackoverflow.com/questions/20969331/standard-method-for-http-partial-upload-resume-upload . There is also tus but I'm not sure about its compatibility with WebDAV.

Generally this is the problem which is killing WebDAV IMHO. But that's off topic here :wink:.