[WIP] Pizza and modalz - Githubissues

councilforeconed / interactive-activities

Council for Economic Education

http://interactives.councilforeconed.org

Mozilla Public License 2.0

6 stars 2 forks source link

[WIP] Pizza and modalz #102

Closed ZeeJab closed 10 years ago

ZeeJab commented 10 years ago

@stevekinney I rebased this with master, and now some tests are failing? Can you take a look please :-(

stevekinney commented 10 years ago

@ZeeJab Good news and bad news. Good news: The tests for mathz-and-modalz pass on my setup. Bad news: I don't know why they fail on yours. Which tests are failing?

ZeeJab commented 10 years ago

neverminddd! i forgot to npm install :-p how does it look so far?

stevekinney commented 10 years ago

It's looking pretty great!

zfb

Some thoughts and questions (knowing full well that it's still a work in progress and you probably have solutions for some/most of these planned):

It seems like there are both anchovies and olives after all, whoops. I just might look into cutting out the anchovies in a effort to keep it close to the book.
In the original one there were multiple pizzas on the conveyor belt. That way multiple students from the group can grab one, work on it, and put it back. The conveyor belt should have all pizzas not currently being worked on by another student.
Do we need an empty plate for the area we drag the pizza onto instead of a plate with a pizza already on it?

stevekinney commented 10 years ago

@ZeeJab Also, if you need anything from @iamjessklein, we should probably let her know soon! :bride_with_veil:

ZeeJab commented 10 years ago

haha, I've been making the png's from the ai file, so I think we're all set with assets from :bride_with_veil: for now

Re: Pizza and conveyor... Yes, confirm. I'll replace both with just the plate

stevekinney commented 10 years ago

@ZeeJab Yea, it should show the pizza in it's current state in the conveyor belt. If it makes sense to grab a cup of coffee in Manhattan (or I can head over the Mozilla office) so I can show you how the lesson works or something that works—I am always looking for an excuse to get out of the office.

ZeeJab commented 10 years ago

@stevekinney Do you wanna meet at Flatiron School at 5 today? We can do a pre-man.js pair session

stevekinney commented 10 years ago

Yea, that sounds like a good plan.

On Wed, Jun 25, 2014 at 12:19 PM, Zahra Jabini notifications@github.com wrote:

Do you wanna meet at Flatiron School at 5 today? We can do a pre-man.js pair session

— Reply to this email directly or view it on GitHub https://github.com/councilforeconed/cee/pull/102#issuecomment-47124492.

ZeeJab commented 10 years ago

@stevekinney hi! Do you want to either pull this or merge it and then help me with a few things?

[ ] I updated all the conveyor stuff to what they should be... but I think you said you need to get rid of anchovies?
[ ] The productivity report renders all sorts of effed, and I'm not sure how to fix it in the js -- >
[ ] other than those things I think the Pizza round is ready?

ZeeJab commented 10 years ago

[update]: I think it should be merged before you work on it... it's too big for more changes?

stevekinney commented 10 years ago

@ZeeJab, Alright, I think know how to fix that. I'm going to merge and then pull it down to take a look!