Minor UI Improvements - Githubissues

councilforeconed / interactive-activities

Council for Economic Education

http://interactives.councilforeconed.org

Mozilla Public License 2.0

6 stars 2 forks source link

Closed jugglinmike closed 10 years ago

jugglinmike commented 10 years ago

Increase the feedback given to users in the following situations:

Page visit with JavaScript disabled (provide resource with instructions on how to enable JavaScript)
Initial page load (display full-screen "Loading" dialog)
Activity load (display "Loading" dialog within activity list item)

mzgoddard commented 10 years ago

@jugglinmike Just one tiny thing. More a theory question than a need.

mzgoddard commented 10 years ago

@jugglinmike Needs a rebase after my room management home page link PR was merged.

mzgoddard commented 10 years ago

Or well yes. That was a silly comment for me to make.

This looks good. Squash/rebase and I'll merge.

jugglinmike commented 10 years ago

@mzgoddard Rebased (resolved conflict by adding a .loading-screen element to the new "Create Activity Room" list item)

jugglinmike commented 10 years ago

...and then I fixed the typo in the commit message