counteragent / Camera-Control

PTZOptics Camera Control Software (Electron App)
GNU General Public License v3.0
36 stars 18 forks source link

Application Process not stopping on close #4

Open nlvw opened 6 years ago

nlvw commented 6 years ago

When closing the electron built application the process in task manager does not close. Same behaviour when you right click the title bar and select close and when you close it from the taskbar. The correct behavior should be for the process to stop when the program is closed.

I think the bug or missing code is in main.js but I'm not familiar enough with electron to fix it.

Build Commands Used (Win 10 x64): npm install npm install electron-packager -g electron-packager . PTZOptics

Process: ptzoptics

nlvw commented 6 years ago

Tried to rebuild this using electron-builder as well. Same behaviour.

Build Commands Used (Win 10 x64)" yarn yarn dist

32bit and 64bit builds behave the same. image

ParadoxGuitarist commented 4 years ago

You actually need to uncomment lines75-77

So they should look like:

    if (process.platform !== 'darwin') {
        app.quit();
    }