sentry logging cleanup - Githubissues

counterdata-network / story-processor

Story discovery engine for the Counterdata Network. Grabs relevant stories from various APIs, runs them against bespoke classifier models, post results to a central server.

Apache License 2.0

0 stars 2 forks source link

sentry logging cleanup #54

Closed adityagurnani22 closed 11 months ago

adityagurnani22 commented 11 months ago

Fixes # Design discussion issue #

Changes

Have made some changes to avoid logging errors from story-processors. Most of the logs are covered by 'scrapy.core.scraper' Also added some functionality to check and ignore other logs that can be ignored as previously discussed.

Merge requirement checklist

[ ] Unit tests added/updated
[ ] Doc-strings & documentation added/updated

adityagurnani22 commented 11 months ago

I have made the required changes and removed checking for error strings. Only checking for specific exceptions to be ignored and the specific loggers to be ignored. Please confirm if this works or if the before_send function should be completely removed and only the code to ignore specific loggers be retained.

rahulbot commented 11 months ago

This is in draft, but I think is ready to merge. Is that right?

adityagurnani22 commented 11 months ago

Yes, this PR is ready to merge. Should I move ahead and merge it with the main branch?