countmodula / VCVRackPlugins

Plugins for VCV Rack
Other
61 stars 11 forks source link

V2.0.0 compile fails in Palette after beta update to git.588342d7 #79

Closed fractalgee closed 3 years ago

fractalgee commented 3 years ago

Here is the compile error on windows 10 latest:

g++ -std=c++11 -Wsuggest-override  -fPIC -I/home/<user>/Rack-SDK/include -I/home/<user>/Rack-SDK/dep/include -MMD -MP -g -O3 -march=nehalem -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_WIN -D_USE_MATH_DEFINES -municode  -c -o build/src/modules/Palette.cpp.o src/modules/Palette.cpp
src/modules/Palette.cpp: In member function 'virtual void Palette::process(const rack::engine::Module::ProcessArgs&)':
src/modules/Palette.cpp:480:23: error: 'struct rack::app::RackWidget' has no member named 'nextCableColorId'
  480 |     APP->scene->rack->nextCableColorId = startColorID;
      |                       ^~~~~~~~~~~~~~~~
src/modules/Palette.cpp:485:36: error: 'struct rack::app::RackWidget' has no member named 'nextCableColorId'
  485 |    int colorID = APP->scene->rack->nextCableColorId;
      |                                    ^~~~~~~~~~~~~~~~
src/modules/Palette.cpp:491:35: error: 'struct rack::app::RackWidget' has no member named 'nextCableColorId'
  491 |       colorID = APP->scene->rack->nextCableColorId = nextColorID;
      |                                   ^~~~~~~~~~~~~~~~
src/modules/Palette.cpp: In member function 'virtual void KeyContainer::step()':
src/modules/Palette.cpp:530:24: error: 'struct rack::app::RackWidget' has no member named 'nextCableColorId'
  530 |      APP->scene->rack->nextCableColorId = i;
      |                        ^~~~~~~~~~~~~~~~
src/modules/Palette.cpp: In member function 'virtual void PaletteWidget::ColourButton::onButton(const Button&)':
src/modules/Palette.cpp:1257:24: error: 'struct rack::app::RackWidget' has no member named 'nextCableColorId'
 1257 |      APP->scene->rack->nextCableColorId = colorID;
      |                        ^~~~~~~~~~~~~~~~
src/modules/Palette.cpp: In member function 'virtual void PaletteWidget::onHoverKey(const HoverKey&)':
src/modules/Palette.cpp:1454:27: error: 'struct rack::app::RackWidget' has no member named 'nextCableColorId'
 1454 |         APP->scene->rack->nextCableColorId = i;
      |                           ^~~~~~~~~~~~~~~~
make: *** [/home/<user>/Rack-SDK/compile.mk:70: build/src/modules/Palette.cpp.o] Error 1
AdamVerspaget commented 3 years ago

Module access to the rack cable colour mechanism was removed in the 588342d7 API update. I have worked with Andrew to have a replacement mechanism which has now been done. https://github.com/countmodula/VCVRackPlugins/commit/162d08f573c52a207c638d109738956df7c9fb3d along with the latest Rack API resolves this issue