countmodula / VCVRackPlugins

Plugins for VCV Rack
Other
61 stars 10 forks source link

Hyper Manical LFO Expander does not honor the bi/uni setting set on main module #97

Closed fractalgee closed 1 year ago

fractalgee commented 1 year ago

Rack 2.12, MacOS 13.0, v 2.2.0 of Count Modula plugin.

Attached patch shows that the expander ignores the main modules setting for bi/uni LFOs. Remove .zip suffix, just added to archive name due to git not liking .vcv archives. Start the polyrhythmic Clock top left, second module next to reset. I would need to stick 6 attenuverters in-between to get them all uni or bi, if main is set differently, should the expander not honor main module's setting? Or at least provide the option in right-click menu (more flexible but less intuitive)

FG_R2_126_04_Bridges_Fun.vcv.zip

AdamVerspaget commented 1 year ago

Hi. The expander was never intended to have unipolar output but I'll see if I can find a good way to implement it without breaking existing patches.

fractalgee commented 1 year ago

would it not be best to have it honor the main module setting? Maybe make it a right-click menu option to follow the main's setting, that way everything will stay same if not enabled. I just feel that is the intuitive way to use any expander.....

Thanks!

On Sat, 29 Oct 2022 at 00:32, AdamVerspaget @.***> wrote:

Hi. The expander was never intended to have unipolar output but I'll see if I can find a good way to implement it without breaking existing patches.

— Reply to this email directly, view it on GitHub https://github.com/countmodula/VCVRackPlugins/issues/97#issuecomment-1295565621, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7FMACWL2YOKSTHP237KY3WFRH6VANCNFSM6AAAAAARO66M54 . You are receiving this because you authored the thread.Message ID: @.***>

AdamVerspaget commented 1 year ago

I've added a context menu item that lets you select Bipolar, Unipolar or Follow LFO for the output mode. If you select "Follow LFO", the outputs follow the button on the LFO. You can select this and save a default preset to have it enabled every time you add a new expander. This will go into the v2.3.0 release; not sure when that will be though.

fractalgee commented 1 year ago

Perfect Adam, thanks!

On Wed, 2 Nov 2022 at 01:10, AdamVerspaget @.***> wrote:

I've added a context menu item that lets you select Bipolar, Unipolar or Follow LFO for the output mode. If you select "Follow LFO", the outputs follow the button on the LFO. You can select this and save a default preset to have it enabled every time you add a new expander. This will go into the v2.3.0 release; not sure when that will be though.

— Reply to this email directly, view it on GitHub https://github.com/countmodula/VCVRackPlugins/issues/97#issuecomment-1299379157, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7FMAFDIJHFZQT6EBRREFLWGGWPDANCNFSM6AAAAAARO66M54 . You are receiving this because you authored the thread.Message ID: @.***>