countries / country_select

Gemification of rails's country_select
https://country-select-demo.onrender.com
MIT License
699 stars 197 forks source link

High memory consumption #107

Closed fabien7337 closed 9 years ago

fabien7337 commented 9 years ago

Using http://engineering.heroku.com/blogs/2015-08-06-patching-rails-performance/

country_select consumes 26M, mostly because of iso3166.

stefanpenner commented 9 years ago

Although this affects country_select, I believe the relevant source is at: https://github.com/hexorx/countries/ I would recommend opening an issue there as well.

and finally https://rubygems.org/gems/iso4217 will need to be adjusted. I suspect the various tricks used in the heroku blog post can be wholesale applied to the iso4217 gem.

dgilperez commented 9 years ago

Countries gem just released a new version to address this issue: https://github.com/hexorx/countries/pull/285

They hit 1.0, with a few major changes, so we cannot use it directly with current version of country_select

scudco commented 9 years ago

Fixed by #108

fabien7337 commented 9 years ago

Well done!