search

countries / country_select

Gemification of rails's country_select
https://country-select-demo.onrender.com
MIT License
704 stars 198 forks source link

Adding support for Rails 7.1 after recent Form Options helper changes #219

Closed ron-shinall closed 1 year ago

ron-shinall commented 1 year ago

A recent Rails Edge commit (https://github.com/rails/rails/commit/77f3fc118a211c973bc3ca0b720dcba932474f89) moves the Form Options helper into select rendering classes. This is a breaking change for country_select.

This PR adds support for the changes, and it has been tested with all of the versions of Rails that country_select supports.

If the approach I've used is not what you prefer, perhaps it will spark some additional ideas for addressing the issue.

scudco commented 1 year ago

@ron-shinall can you add 7.1 to the Github test workflow's gemfile matrix at .github/workflows/test.yml?

ron-shinall commented 1 year ago

@scudco sorry I missed that! I've added it and all checks have passed.

swistaczek commented 1 year ago

Hey @pmor, are there any chances you will be able to release an updated gem soon :)?

pmor commented 1 year ago

I'm traveling, but next week I should be able to take care of it.