Closed courageousillumination closed 9 years ago
Sub-issues:
Are there unittests for this?
All the subissues are irrelevant, now. Tristan's individualized pushing described in the visibility issue makes most of this easy. The only difficulty now is in changing the region ids at set up. Working on that test now.
After working through it for a while, Shaan and I realized that the testing part is mostly covered in test_config_with_owners. The rest is in sending the zoneids appropriately, which Shaan is writing a test for right now.
Since the javascript needs to iterate through the zones based on each player's layout, this data needs to be passed through the sockets which comes from the game runner and game objects. This requires a lot of objects to be mocked and reduces the value of the test, so we will transform this test into an integration test since data passed back and forth between multiple layers.
I think this is all done on the hearts branch.
Right now zones won't really work well with multiple players. Since zones are hardcoded in it's possible that a player will be playing upside down or sideways. Zones ought to have a way of dealing with this.