search

courageousillumination / deckr

A Card Game Engine for CMSC 22001
MIT License
6 stars 1 forks source link

Socket tests failing #58

Closed jcarpenterhoughton closed 9 years ago

jcarpenterhoughton commented 9 years ago

Socket tests are failing because it was expecting state_transition and a [{}], but got info_string and "[{}]". Did we refactor a new way to express the state, or is there a more serious problem? I've been looking over the code, and will continue to do so, but this would speed things up a bit.

courageousillumination commented 9 years ago

Is this happening on master?

jcarpenterhoughton commented 9 years ago

It's happening on min-players and remove_player, at least as far as I can tell. I just don't want to merge them into master because I worry they'd break it. I haven't checked master yet.

jcarpenterhoughton commented 9 years ago

Ok. Not on master. I'll just merge them in and make sure that any changes in socket.py are carefully examined.

courageousillumination commented 9 years ago

No don't merge them in until all the tests are passing. I would try debasing from master. I didn't work on those so I can't say much else.

jcarpenterhoughton commented 9 years ago

Alright. I'll see if I can keep fixing them up.

jcarpenterhoughton commented 9 years ago

This is done