master: icon_url is not used if icon_emoji is blank

coursehero / slacktee

slacktee is a bash script that works like tee command. Instead of writing the standard input to files, slacktee posts it to Slack.

Apache License 2.0

830 stars 95 forks source link

master: icon_url is not used if icon_emoji is blank #77

Closed gilesw closed 3 years ago

Chikashi-Kato commented 3 years ago

Thank you for the PR, @gilesw! Let me review it

Chikashi-Kato commented 3 years ago

Sorry for taking time to review your PR! It looks good and merging it into master! I found the same issue in the streaming mode and will fix it in another PR. Thank you so much for your contribution, @gilesw!

Chikashi-Kato commented 3 years ago

I will release a new version for this PR along with #78.